summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Eggleton <paul.eggleton@linux.intel.com>2012-01-19 14:36:03 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-01-20 16:40:07 +0000
commite44d5be98fc5d2589cd929ce143638395936b936 (patch)
tree6925ba4a911c6eabfd9339043ff4de2aadb4b228
parent7da7dff83ed765c9cde1d7f91ee1b65e49520481 (diff)
downloadbitbake-e44d5be98fc5d2589cd929ce143638395936b936.tar.gz
bitbake/runqueue: always log tasks summary
It's unclear from the history but at some point we stopped logging the "Tasks Summary" NOTE when tasks failed. Reinstate this for failure, and also make the count of attempted tasks include the failed task. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/bb/runqueue.py12
1 files changed, 7 insertions, 5 deletions
diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index 12ebdf959..0db537716 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -959,6 +959,13 @@ class RunQueue:
if self.state is runQueueCleanUp:
self.rqexe.finish()
+ if self.state is runQueueComplete or self.state is runQueueFailed:
+ if self.rqexe.stats.failed:
+ logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed + self.rqexe.stats.failed, self.rqexe.stats.skipped, self.rqexe.stats.failed)
+ else:
+ # Let's avoid the word "failed" if nothing actually did
+ logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and all succeeded.", self.rqexe.stats.completed, self.rqexe.stats.skipped)
+
if self.state is runQueueFailed:
if not self.rqdata.taskData.tryaltconfigs:
raise bb.runqueue.TaskFailure(self.rqexe.failed_fnids)
@@ -968,11 +975,6 @@ class RunQueue:
if self.state is runQueueComplete:
# All done
- if self.rqexe.stats.failed:
- logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and %d failed.", self.rqexe.stats.completed, self.rqexe.stats.skipped, self.rqexe.stats.failed)
- else:
- # Let's avoid the word "failed" if nothing actually did
- logger.info("Tasks Summary: Attempted %d tasks of which %d didn't need to be rerun and all succeeded.", self.rqexe.stats.completed, self.rqexe.stats.skipped)
return False
if self.state is runQueueChildProcess: