summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2011-08-12 15:25:58 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2011-08-15 09:33:10 +0100
commit7627b561cbcb1482b464d69db70f38ea663180f3 (patch)
tree5df27b52f1a82e5fe2544c9d32826f1829bd9f90
parent29afbf10c00b5ccdd8d2c063dda3f3e2b6aa1624 (diff)
downloadbitbake-7627b561cbcb1482b464d69db70f38ea663180f3.tar.gz
bitbake/msg.py: Drop manually created domain lists
This patch removes the majority of the domain related code from bb.msg on the grounds that we now support dynamic creation of logging domains so having this hardcoded is just error prone and less flexible. It also makes the msg code overly and needlessly complex. It also removes the bb.msg.debug/note/warn/plain/error functions since we might as well remove them rather than try and fix them at this point. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/bb/msg.py85
1 files changed, 4 insertions, 81 deletions
diff --git a/lib/bb/msg.py b/lib/bb/msg.py
index 77a7a0fed..ecf756ee2 100644
--- a/lib/bb/msg.py
+++ b/lib/bb/msg.py
@@ -94,35 +94,6 @@ class BBLogFilter(object):
return False
-class Loggers(dict):
- def __getitem__(self, key):
- if key in self:
- return dict.__getitem__(self, key)
- else:
- log = logging.getLogger("BitBake.%s" % domain._fields[key])
- dict.__setitem__(self, key, log)
- return log
-
-def _NamedTuple(name, fields):
- Tuple = collections.namedtuple(name, " ".join(fields))
- return Tuple(*range(len(fields)))
-
-domain = _NamedTuple("Domain", (
- "Default",
- "Build",
- "Cache",
- "Collection",
- "Data",
- "Depends",
- "Fetcher",
- "Parsing",
- "PersistData",
- "Provider",
- "RunQueue",
- "TaskData",
- "Util"))
-logger = logging.getLogger("BitBake")
-loggers = Loggers()
# Message control functions
#
@@ -156,11 +127,6 @@ def addDefaultlogFilter(handler):
for (domainarg, iterator) in groupby(domains):
dlevel = len(tuple(iterator))
debug_domains["BitBake.%s" % domainarg] = logging.DEBUG - dlevel + 1
- for index, msgdomain in enumerate(domain._fields):
- if msgdomain == domainarg:
- break
- else:
- warn(None, "Logging domain %s is not valid, ignoring" % domainarg)
BBLogFilter(handler, level, debug_domains)
@@ -168,53 +134,10 @@ def addDefaultlogFilter(handler):
# Message handling functions
#
-def debug(level, msgdomain, msg):
- warnings.warn("bb.msg.debug is deprecated in favor of the python 'logging' module",
- DeprecationWarning, stacklevel=2)
- level = logging.DEBUG - (level - 1)
- if not msgdomain:
- logger.debug(level, msg)
- else:
- loggers[msgdomain].debug(level, msg)
-
-def plain(msg):
- warnings.warn("bb.msg.plain is deprecated in favor of the python 'logging' module",
- DeprecationWarning, stacklevel=2)
- logger.plain(msg)
-
-def note(level, msgdomain, msg):
- warnings.warn("bb.msg.note is deprecated in favor of the python 'logging' module",
- DeprecationWarning, stacklevel=2)
- if level > 1:
- if msgdomain:
- logger.verbose(msg)
- else:
- loggers[msgdomain].verbose(msg)
- else:
- if msgdomain:
- logger.info(msg)
- else:
- loggers[msgdomain].info(msg)
-
-def warn(msgdomain, msg):
- warnings.warn("bb.msg.warn is deprecated in favor of the python 'logging' module",
- DeprecationWarning, stacklevel=2)
- if not msgdomain:
- logger.warn(msg)
- else:
- loggers[msgdomain].warn(msg)
-
-def error(msgdomain, msg):
- warnings.warn("bb.msg.error is deprecated in favor of the python 'logging' module",
- DeprecationWarning, stacklevel=2)
- if not msgdomain:
- logger.error(msg)
- else:
- loggers[msgdomain].error(msg)
-
def fatal(msgdomain, msg):
- if not msgdomain:
- logger.critical(msg)
+ if msgdomain:
+ logger = logging.getLogger("BitBake.%s" % msgdomin)
else:
- loggers[msgdomain].critical(msg)
+ logger = logging.getLogger("BitBake")
+ logger.critical(msg)
sys.exit(1)