diff options
| author |   Scott Garman <scott.a.garman@intel.com> | 2011-06-19 16:15:25 -0700 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-06-22 16:24:43 +0100 |
| commit | a2a29b72275ab03a263f4479a590b92111a0d6a8 (patch) | |
| tree | 8a676dfd75286c3da94734edbcdbe5e152539a88 | |
| parent | d97f7d762e3d2f1b0da038d4d99f2531b2490670 (diff) | |
| download | bitbake-a2a29b72275ab03a263f4479a590b92111a0d6a8.tar.gz | |
fetch2/git.py: improve error reporting when an invalid protocol is used
When an invalid 'protocol' parameter is used in a git SRC_URI,
the error reported was not helpful:
ERROR: Function 'Fetcher failure for URL: 'None'.
<environment dump>
fatal: Could not make temporary directory: No such file or directory
So instead check that ud.proto is set to something valid, and if not
raise a meaningful ParameterError which explains that the protocol
type is the source of the problem.
This fixes bug [YOCTO #1142]
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/fetch2/git.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py index 6979beaef..f3bc793a6 100644 --- a/lib/bb/fetch2/git.py +++ b/lib/bb/fetch2/git.py @@ -88,6 +88,9 @@ class Git(FetchMethod): else: ud.proto = "git" + if not ud.proto in ('git', 'file', 'ssh', 'http', 'https'): + raise bb.fetch2.ParameterError("Invalid protocol type", ud.url) + ud.nocheckout = ud.parm.get("nocheckout","0") == "1" ud.rebaseable = ud.parm.get("rebaseable","0") == "1" |