From 100b447a161ef20fa559e39516cd32fa78e38262 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Fri, 24 Jul 2015 11:41:44 +0100 Subject: data_smart: Improve override history logging Calling record() for each override alteration is slow. Since we now expand overrides dynamically we don't have to record the log data at each alteration, we can instead print it directly from the existing data stores at variable history print time using the exact same data stores. This massively improves performance of the data store when parsing with bitbake -e for example, it will improve memory overhead as well. The only downside is that VariableHistory has to poke into the datastore for some of its data but that seems an acceptable tradeoff rather than double caching. Signed-off-by: Richard Purdie --- lib/bb/data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/bb/data.py') diff --git a/lib/bb/data.py b/lib/bb/data.py index a21de112e..f6415a467 100644 --- a/lib/bb/data.py +++ b/lib/bb/data.py @@ -202,7 +202,7 @@ def emit_var(var, o=sys.__stdout__, d = init(), all=False): return False if all: - d.varhistory.emit(var, oval, val, o) + d.varhistory.emit(var, oval, val, o, d) if (var.find("-") != -1 or var.find(".") != -1 or var.find('{') != -1 or var.find('}') != -1 or var.find('+') != -1) and not all: return False -- cgit 1.2.3-korg