aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2018-10-09 18:59:25 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2018-10-10 13:21:43 +0100
commit66ac33b6888edb7077b6e94a4d3d1e1d1d53c0c5 (patch)
treec9481a59de5e60dd0a23b057c9a28ab80b7cdbd9
parent99321236c516277c9d423b1b355bbce1245d9923 (diff)
downloadbitbake-contrib-66ac33b6888edb7077b6e94a4d3d1e1d1d53c0c5.tar.gz
main: Fix environment handling for UI module imports
The environment was being cleared before the UI imports occurred which caused problems for graphical UIs like taskexp. The full environment was intended to be available to UI clients and it was only meant to be cleared for the server/cooker, so tweak the code order so this is the case. This fixes problems reported for taskexp. [YOCTO #12670] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rwxr-xr-xlib/bb/main.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/bb/main.py b/lib/bb/main.py
index f4474e410..732a31540 100755
--- a/lib/bb/main.py
+++ b/lib/bb/main.py
@@ -405,9 +405,6 @@ def setup_bitbake(configParams, configuration, extrafeatures=None):
# In status only mode there are no logs and no UI
logger.addHandler(handler)
- # Clear away any spurious environment variables while we stoke up the cooker
- cleanedvars = bb.utils.clean_environment()
-
if configParams.server_only:
featureset = []
ui_module = None
@@ -423,6 +420,10 @@ def setup_bitbake(configParams, configuration, extrafeatures=None):
server_connection = None
+ # Clear away any spurious environment variables while we stoke up the cooker
+ # (done after import_extension_module() above since for example import gi triggers env var usage)
+ cleanedvars = bb.utils.clean_environment()
+
if configParams.remote_server:
# Connect to a remote XMLRPC server
server_connection = bb.server.xmlrpcclient.connectXMLRPC(configParams.remote_server, featureset,