diff options
| author |   Gavin Li <gavin@matician.com> | 2019-11-11 14:17:39 -0800 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-11-13 22:36:59 +0000 |
| commit | c45b0140c37f2d68c4fa08cd17f0321b8d6524a8 (patch) | |
| tree | 089a5ce9e88d191685b4295d060a6ee31ce18670 | |
| parent | 8962b27abc68427eae085624f26300108ae88aa1 (diff) | |
| download | bitbake-contrib-c45b0140c37f2d68c4fa08cd17f0321b8d6524a8.tar.gz | |
prserv: fix ResourceWarning due to unclosed socket
With PRSERV_HOST = "localhost:0", this message would occasionally pop up
during the initial cache read:
WARNING: /home/matic/ambayocto/poky/bitbake/lib/bb/cache.py:446: ResourceWarning: unclosed <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 45655)>
value = pickled.load()
The file location stated is irrelevant; it just happens to be wherever
CPython decides to run the garbage collector. The issue is that after we
fork off a PRServer, self.socket is also duplicated. The parent side of
it also needs to be closed.
Signed-off-by: Gavin Li <gavin@matician.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/prserv/serv.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/prserv/serv.py b/lib/prserv/serv.py index 2bc68904f..b854ba14b 100644 --- a/lib/prserv/serv.py +++ b/lib/prserv/serv.py @@ -243,6 +243,7 @@ class PRServer(SimpleXMLRPCServer): try: pid = os.fork() if pid > 0: + self.socket.close() # avoid ResourceWarning in parent return pid except OSError as e: raise Exception("%s [%d]" % (e.strerror, e.errno)) |