From dac68d2323b0b630c019ce4d5256ed567eaf00da Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Tue, 11 Jul 2017 17:34:24 +0300 Subject: runqemu: check exit code of 'ls -t' Used check_output instead of Popen as it raises CalledProcessError exception when command exits with non-zero exit code. Catched the exception to produce user-friendly output. [YOCTO #11719] Signed-off-by: Ed Bartosh Signed-off-by: Ross Burton --- scripts/runqemu | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'scripts') diff --git a/scripts/runqemu b/scripts/runqemu index c33741d804..d44afc7e7a 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -676,7 +676,10 @@ class BaseConfig(object): else: cmd = 'ls -t %s/*.qemuboot.conf' % deploy_dir_image logger.info('Running %s...' % cmd) - qbs = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE).stdout.read().decode('utf-8') + try: + qbs = subprocess.check_output(cmd, shell=True).decode('utf-8') + except subprocess.CalledProcessError as err: + raise RunQemuError(err) if qbs: for qb in qbs.split(): # Don't use initramfs when other choices unless fstype is ramfs -- cgit 1.2.3-korg