aboutsummaryrefslogtreecommitdiffstats
path: root/meta/recipes-core
AgeCommit message (Collapse)Author
2017-02-01build-appliance-image: Update to master head revisionRichard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-02-01meta-environment: Clean up the task structure to reduce manifest warningsRichard Purdie
This puts the dependencies on the correct task and removes pointless noexec tasks allowing for a slightly cleaner task structure. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-31core-image-tiny-initramfs: Fix error message shown after a successful initrd ↵Alejandro Hernandez
boot When booting core-image-tiny-initramfs, since we want to live on initrd, on purpose, we never find a rootfs image to switch root to, this causes init to show an error as it would with other images, this patch replaces the message shown to the user, avoiding confusion when it was indeed a successful boot. Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
2017-01-31core-image-tiny-initramfs: Add and image creating image artifacts onlyTom Zanussi
Add an image that simply creates image artifacts using image-live-artifacts support instead of creating an actual image. The image artifacts can then be subsequently assembled by an external tool such as wic to create an actual image. This eliminates redundant image creation when using such tools. Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
2017-01-31util-linux: create own package for lsblkAndreas Oberritter
Let util-linux-bash-completion depend on it, because it uses it. Signed-off-by: Andreas Oberritter <obi@opendreambox.org> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-31wic-tools: add dependency to systemd-bootEd Bartosh
Added systemd-boot to the list of dependencies of wic-tools as wic bootimg-efi plugin depends on it. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
2017-01-31wic: change location of .env filesEd Bartosh
Current location of .env files $STAGING_DIR/imagedata. It doesn't depend on machine and be rewritten by the builds for different machines. Changed location to $STAGING_DIR/$MACHINE/imagedata to avoid .env files to be rewritten. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-28libxml2: Drop docs in native caseRichard Purdie
With rss, moving these around was having an increasing overhead and we don't need them in the native case so remove them. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-28gzip/pigz/expat/image: Simplify gzip-native/pigz-nativeRichard Purdie
With recipe specific sysroots, the gzip-replacement-native dance/class is obsolete, simplify the code accordingly. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-28image/kernelsrc/packagegroups/recipes: Remove uneeded noexec tasksRichard Purdie
We used to have issues removing tasks like do_fetch due to implications for targets like world and universe. These have now been resolved. Removing uneeded tasks has advantages compared to noexec since it means that accidentally left in dependencies are no longer needed/processed (e.g. do_patch depends on quilt-native). This cleans up a number of cases which local analysis highlighted as being unneeded leading to slightly cleaner task graphs. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-23build-appliance-image: Update to master head revisionRichard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-23busybox: Guard against interrupted compilesRichard Purdie
If busybox is interrupted during do_compile, it can corrupt .config with the suid version, or worse. Typically this leads to files disappearing, particularly /etc/init.d/* which leads to an empty busybox-hwclock. That then results in errors at do_rootfs time due to the missing package. The fix is to use any 'orig' present to restore stat at the start of compile. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-23glibc: Upgrade to 2.25 snapshotKhem Raj
glibc 2.25 release is in freeze stage now Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-23busybox: refresh the flock patchMaxin B. John
Upstream accepted the flock fix with some improvements. Backport those changes. Signed-off-by: Maxin B. John <maxin.john@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-23wic: add wic-tools recipeEd Bartosh
This meta recipe is for building tools used by wic. It allows wic to find tools in recipe specific sysroot as all tools will be present in wic-tools sysroot. NOTE: task do_build_sysroot is created to ensure that sysroot is re-populated when package is built. Otherwise it will be taken from sstate and sysroot will not be populated. Generated wic-tools.env file for wic to be able to get values of wic-tools variables when wic run from bitbake. Also add dependency to grub-efi Without grub-efi test_iso_image test case fails with this error: AssertionError: Command 'wic create mkhybridiso --image-name core-image-minimal' returned non-zero exit status 1: Error: Please build grub-efi first Fixed by adding dependency wic-tools -> grub-efi. [RP: Added syslinux exclusion for non-IA arches] Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-23Switch to Recipe Specific SysrootsRichard Purdie
This patch is comparatively large and invasive. It does only do one thing, switching the system to build using recipe specific sysroots and where changes could be isolated from it, that has been done. With the current single sysroot approach, its possible for software to find things which aren't in their dependencies. This leads to a determinism problem and is a growing issue in several of the market segments where OE makes sense. The way to solve this problem for OE is to have seperate sysroots for each recipe and these will only contain the dependencies for that recipe. Its worth noting that this is not task specific sysroots and that OE's dependencies do vary enormously by task. This did result in some implementation challenges. There is nothing stopping the implementation of task specific sysroots at some later point based on this work but that as deemed a bridge too far right now. Implementation details: * Rather than installing the sysroot artefacts into a combined sysroots, they are now placed in TMPDIR/sysroot-components/PACKAGE_ARCH/PN. * WORKDIR/recipe-sysroot and WORKDIR/recipe-sysroot-native are built by hardlinking in files from the sysroot-component trees. These new directories are known as RECIPE_SYSROOT and RECIPE_SYSROOT_NATIVE. * This construction is primarily done by a new do_prepare_recipe_sysroot task which runs before do_configure and consists of a call to the extend_recipe_sysroot function. * Other tasks need things in the sysroot before/after this, e.g. do_patch needs quilt-native and do_package_write_deb needs dpkg-native. The code therefore inspects the dependencies for each task and adds extend_recipe_sysroot as a prefunc if it has populate_sysroot dependencies. * We have to do a search/replace 'fixme' operation on the files installed into the sysroot to change hardcoded paths into the correct ones. We create a fixmepath file in the component directory which lists the files which need this operation. * Some files have "postinstall" commands which need to run against them, e.g. gdk-pixbuf each time a new loader is added. These are handled by adding files in bindir with the name prefixed by "postinst-" and are run in each sysroot as its created if they're present. This did mean most sstate postinstalls have to be rewritten but there shouldn't be many of them. * Since a recipe can have multiple tasks and these tasks can run against each other at the same time we have to have a lock when we perform write operations against the sysroot. We also have to maintain manifests of what we install against a task checksum of the dependency. If the checksum changes, we remove its files and then add the new ones. * The autotools logic for filtering the view of m4 files is no longer needed (and was the model for the way extend_recipe_sysroot works). * For autotools, we used to build a combined m4 macros directory which had both the native and target m4 files. We can no longer do this so we use the target sysroot as the default and add the native sysroot as an extra backup include path. If we don't do this, we'd have to build target pkg-config before we could built anything using pkg-config for example (ditto gettext). Such dependencies would be painful so we haven't required that. * PKDDATA_DIR was moved out the sysroot and works as before using sstate to build a hybrid copy for each machine. The paths therefore changed, the behaviour did not. * The ccache class had to be reworked to function with rss. * The TCBOOTSTRAP sysroot for compiler bootstrap is no longer needed but the -initial data does have to be filtered out from the main recipe sysroots. Putting "-initial" in a normal recipe name therefore remains a bad idea. * The logic in insane needed tweaks to deal with the new path layout, as did the debug source file extraction code in package.bbclass. * The logic in sstate.bbclass had to be rewritten since it previously only performed search and replace on extracted sstate and we now need this to happen even if the compiled path was "correct". This in theory could cause a mild performance issue but since the sysroot data was the main data that needed this and we'd have to do it there regardless with rss, I've opted just to change the way the class for everything. The built output used to build the sstate output is now retained and installed rather than deleted. * The search and replace logic used in sstate objects also seemed weak/incorrect and didn't hold up against testing. This has been rewritten too. There are some assumptions made about paths, we save the 'proper' search and replace operations to fixmepath.cmd but then ignore this. What is here works but is a little hardcoded and an area for future improvement. * In order to work with eSDK we need a way to build something that looks like the old style sysroot. "bitbake build-sysroots" will construct such a sysroot based on everything in the components directory that matches the current MACHINE. It will allow transition of external tools and can built target or native variants or both. It also supports a clean task. I'd suggest not relying on this for anything other than transitional purposes though. To see XXX in that sysroot, you'd have to have built that in a previous bitbake invocation. * pseudo is run out of its components directory. This is fine as its statically linked. * The hacks for wayland to see allarch dependencies in the multilib case are no longer needed and can be dropped. * wic needed more extensive changes to work with rss and the fixes are in a separate commit series * Various oe-selftest tweaks were needed since tests did assume the location to binaries and the combined sysroot in several cases. * Most missing dependencies this work found have been sent out as separate patches as they were found but a few tweaks are still included here. * A late addition is that extend_recipe_sysroot became multilib aware and able to populate multilib sysroots. I had hoped not to have to add that complexity but the meta-environment recipe forced my hand. That implementation can probably be neater but this is on the list of things to cleanup later at this point. In summary, the impact people will likely see after this change: * Recipes may fail with missing dependencies, particularly native tools like gettext-native, glib-2.0-native and libxml2.0-native. Some hosts have these installed and will mask these errors * Any recipe/class using SSTATEPOSTINSTFUNCS will need that code rewriting into a postinst * There was a separate patch series dealing with roots postinst native dependency issues. Any postinst which expects native tools at rootfs time will need to mark that dependency with PACKAGE_WRITE_DEPS. There could well be other issues. This has been tested repeatedly against our autobuilders and oe-selftest and issues found have been fixed. We believe at least OE-Core is in good shape but that doesn't mean we've found all the issues. Also, the logging is a bit chatty at the moment. It does help if something goes wrong and goes to the task logfiles, not the console so I've intentionally left this like that for now. We can turn it down easily enough in due course. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-20meta-environment: Ensure all multilib dependencies are accounted forRichard Purdie
Currently the recipe depends on the mulitlib libcs all being built but the dependencies don't account for this. Fix the DEPENDS so that the requires pieces are all built first rather than relying on luck. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-19dbus: Add PACKAGE_WRITE_DEPS for postinstJussi Kukkonen
systemctl is needed if both systemd and sysvinit are in distro features. Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
2017-01-19systemd: Add PACKAGE_WRITE_DEPS for postinstJussi Kukkonen
Qemu is used to run udevadm in postinstall. Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
2017-01-19eudev: Add PACKAGE_WRITE_DEPS for postinstallJussi Kukkonen
Qemu is used to run udevadm in postinstall. Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
2017-01-19systemd-compat-units: Add PACKAGE_WRITE_DEPS for postinstRichard Purdie
The postinstall needs systemd-systemctl-native, mark the dependency Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-19psplash: Add PACKAGE_WRITE_DEPS for postinstRichard Purdie
The postinstall needs systemd-systemctl-native, mark the dependency Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-19initscripts: Add PACKAGE_WRITE_DEPS for postinstRichard Purdie
The postinstall needs systemd-systemctl-native, mark the dependency Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-19classes/populate_sdk_ext: force a known value for TMPDIRPaul Eggleton
If TMPDIR is configured to be somewhere outside of TOPDIR (a not uncommon configuration where you have multiple disks and space on /home is at a premium) then our attempt to find out the location of paths under TMPDIR by using a relative path led to horribly broken paths ending up in the eSDK. To save pain, just force a known value for TMPDIR (i.e. ${TOPDIR}/tmp) and then we can assume that everywhere else. Fixes [YOCTO #10797]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-19netbase: upgrade to version 5.4Maxin B. John
5.3 -> 5.4 Refreshed the following patch: a) netbase-add-rpcbind-as-an-alias-to-sunrpc.patch Signed-off-by: Maxin B. John <maxin.john@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-16build-appliance-image: support for ToasterJuro Bystricky
Various changes needed to enable to run Toaster in the Build Appliance: 1. Pre-install packages as specified by the file "bitbake/toaster-requirements.txt" 2. Include pip3 in the image 3. Include tzdata in the image (needed by django) 4. Bump SRCREV to a commit with proper settings.py (ALLOWED_HOSTS) for Django 1.8.16 5. Added README_VirtualBox_Toaster.txt to provide steps for configuring VirtualBox network adapters (NAT or Bridged) and steps to launch Toaster [YOCTO#10767] Signed-off-by: Juro Bystricky <juro.bystricky@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-16coreutils: upgrade to 8.26Chen Qi
Add 0001-local.mk-fix-cross-compiling-problem.patch to fix the following cross compiling problem. | Makefile:3418: *** Recursive variable 'INSTALL' references itself (eventually). Stop. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-16dbus/dbus-test: upgrade to 1.10.14Chen Qi
Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-16musl: Upgrade to 1.1.16+ on masterKhem Raj
summary of changes http://git.musl-libc.org/cgit/musl/commit/?id=8fe1f2d79b275b7f7fb0d41c99e379357df63cd9 Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-09packagegroup-core-tools-profile: exclude valgrind for x32Christopher Larson
valgrind doesn't seem to support x32 at this time, even in current upstream. Signed-off-by: Christopher Larson <chris_larson@mentor.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-09zlib: update SRC_URI to fix fetchingJoshua Lock
Upstream have removed the file from zlib.net as a new version has been released, switch to fetching from the official sourceforge mirror. [YOCTO #10879] Signed-off-by: Joshua Lock <joshua.g.lock@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-09meta: use require instead of include when file should existPaul Eggleton
If the file is expected to exist, then we should always be using require so that if it doesn't we get an error rather than some other more obscure failure later on. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-09gummiboot: Remove/change gummiboot references with systemd-bootAlejandro Hernandez
After systemd-boot was introduced, its been tested for a while with no major issues being found until now, this patch completely replaces all gummiboot instances with systemd-boot ones, taking the next step into cleaning up systemd-boot/gummiboot. [YOCTO #10332] Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2017-01-06meta/scripts: Various getVar/getVarFlag expansion parameter fixesRichard Purdie
There were a few straggling expansion parameter removals left for getVar/getVarFlag where the odd whitespace meant they were missed on previous passes. There were also some plain broken ussages such as: d.getVar('ALTERNATIVE_TARGET', old_name, True) path = d.getVar('PATH', d, True) d.getVar('IMAGE_ROOTFS', 'True') which I've corrected (they happend to work by luck). Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-05packagegroup-self-hosted: add opengl to REQUIRED_DISTRO_FEATURESChristopher Larson
This rdepends on libgl. Signed-off-by: Christopher Larson <chris_larson@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-01-05ifupdown: upgrade to 0.8.16Maxin B. John
Refreshed the following patch: * inet-6-.defn-fix-inverted-checks-for-loopback.patch Signed-off-by: Maxin B. John <maxin.john@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-22ncurses.inc: add v6 binconfig-disabled entriesTrevor Woerner
Newer host distributions are moving to ncurses6, therefore add entries so the host's ncurses{w}6-config scripts aren't picked up. Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-22packagegroup-core-standalone-sdk-target: add libsspPaul Eggleton
If you want to be able to use -fstack-protector then you need the runtime support - you can either write this yourself or use libssp supplied with GCC. If you're using GCC then it seems likely that you'd just be using libssp, so include in the SDK by default; however use RRECOMMENDS just in case it's been disabled or you aren't using GCC. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-22initscripts: populate-volatile: suppress read-only-rootfs warningsAndré Draszik
rm: can't remove '/etc/resolv.conf': Read-only file system ln: /etc/resolv.conf: File exists /etc/default/volatiles contains an entry: l root root 0644 /etc/resolv.conf /var/run/resolv.conf which causes populate-volatile.sh to execute the following in link_file(): if [ -L \"$2\" ]; then [ \"\$(readlink -f \"$2\")\" != \"\$(readlink -f \"$1\")\" ] && { rm -f \"$2\"; ln -sf \"$1\" \"$2\"; }; elif [ -d \"$2\" ]; then ... At the time the image is created, /etc/resolv.conf is already a symlink to /var/run/resolv.conf, but at boot time when populate-volatiles.sh is run, /var/run/resolv.conf doesn't exist, causing it to try to rm -f and ln -sf which of course fails due to the read-only filesystem. [YOCTO #10814] Signed-off-by: André Draszik <adraszik@tycoint.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-22initscripts: populate-volatile: don't run commands in backgroundMans Rullgard
If commands are run asynchronously they may be completed out of order causing problems if later entries depend on earlier ones. Signed-off-by: Mans Rullgard <mans@mansr.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-22systemd: point to correct resolv.conf when resolved is enabledKhem Raj
latest systemd has changed the resolved defaults which points to 127.0.0.53 port 53 on local network. If someone wants to use host-local IP address then it can be pointed to copy in /lib/systemd Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-19glib-2.0: Upgrade 2.50.1 -> 2.50.2Jussi Kukkonen
Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-12-17dbus-glib 0.106 -> 0.108Zheng Ruoqin
Upgrade dbus-glib from 0.106 to 0.108 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-17busybox: add comments to separate Runit from SELinux content in defconfigRobert P. J. Day
There is no break in busybox's "defconfig" file to show where Runit settings suddenly morph into SELinux settings, so add some comments. (From OE-Core rev: 0fa590ed6c26aa065a9da8edbf65436fa1f6d04f) Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-12-17util-linux: 2.28.1 -> 2.29Zheng Ruoqin
Upgrade util-linux from 2.28.1 to 2.29 (From OE-Core rev: a675e8219f09a92f1c9c9fccce449d0f0753a53f) Signed-off-by: Zheng Ruoqin <zhengrq.fnst@cn.fujitsu.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-12-16meta: remove True option to getVar callsJoshua Lock
getVar() now defaults to expanding by default, thus remove the True option from getVar() calls with a regex search and replace. Search made with the following regex: getVar ?\(( ?[^,()]*), True\) Signed-off-by: Joshua Lock <joshua.g.lock@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-16systemd: disable 'libdir' QA checkMark Asselstine
When building systemd with multilib support enabled in your build you will get the following QA warnings (if the 'libdir' QA check is enabled.) WARNING: systemd-1_232-r0 do_package_qa: QA Issue: systemd-dbg: found \ library in wrong location: /lib/systemd/.debug/libsystemd-shared-232.so systemd: found library in wrong location: /lib/systemd/libsystemd-shared.so systemd: found library in wrong location: /lib/systemd/libsystemd-shared-232.so [libdir] Since systemd 231 upstream has included an 'internal' library which they explicitly place in the application specific /lib/systemd directory. You can see some of the discussion about this placement here https://github.com/systemd/systemd/issues/3810 This placement is being picked up by the QA checker since when multilibs are enabled it expects all libraries to be in lib32 or lib64. Since the systemd and systemd-dbg packages don't contain any other libraries we can respect the upstream placement and skip this QA check for these packages. Unfortunately the QA mechanism doesn't allow us to specify individual files so this approach is the best we can do. Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-16libxml2: Fix more NULL pointer derefsAndrej Valek
The NULL pointer dereferencing could produced some security problems. This is a preventive security fix. Signed-off-by: Andrej Valek <andrej.valek@siemens.com> Signed-off-by: Pascal Bach <pascal.bach@siemens.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-16libxml2: fix CVE-2016-4658 Disallow namespace nodes in XPointer points and ↵Andrej Valek
ranges Namespace nodes must be copied to avoid use-after-free errors. But they don't necessarily have a physical representation in a document, so simply disallow them in XPointer ranges. Signed-off-by: Andrej Valek <andrej.valek@siemens.com> Signed-off-by: Pascal Bach <pascal.bach@siemens.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
2016-12-16libxml2: Necessary changes before fixing CVE-2016-5131Andrej Valek
xpath: - Check for errors after evaluating first operand. - Add sanity check for empty stack. - Include comparation in changes from xmlXPathCmpNodesExt to xmlXPathCmpNodes Signed-off-by: Andrej Valek <andrej.valek@siemens.com> Signed-off-by: Pascal Bach <pascal.bach@siemens.com> Signed-off-by: Ross Burton <ross.burton@intel.com>