summaryrefslogtreecommitdiffstats
path: root/meta/recipes-rt/rt-tests/files
diff options
context:
space:
mode:
authorJesse Zhang <sen.zhang@windriver.com>2013-06-17 16:49:13 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2013-06-25 17:30:32 +0100
commit7538a9cd0c6f0216ef95956ad86e2f88ebd4c8ea (patch)
tree0f5e9a3375bb3d7746b54a7d43bd84e9d7c3fc1f /meta/recipes-rt/rt-tests/files
parent1cad5073346bcccbe5bafa3c8876890a0a62615c (diff)
downloadopenembedded-core-7538a9cd0c6f0216ef95956ad86e2f88ebd4c8ea.tar.gz
openembedded-core-7538a9cd0c6f0216ef95956ad86e2f88ebd4c8ea.tar.bz2
openembedded-core-7538a9cd0c6f0216ef95956ad86e2f88ebd4c8ea.zip
rt-tests: fix error check in hackbench
Add a patch to fix when an unsigned number is taken as a negative error code. Signed-off-by: Jesse Zhang <sen.zhang@windriver.com> Signed-off-by: Saul Wold <sgw@linux.intel.com>
Diffstat (limited to 'meta/recipes-rt/rt-tests/files')
-rw-r--r--meta/recipes-rt/rt-tests/files/hackbench-fix-error-check.patch41
1 files changed, 41 insertions, 0 deletions
diff --git a/meta/recipes-rt/rt-tests/files/hackbench-fix-error-check.patch b/meta/recipes-rt/rt-tests/files/hackbench-fix-error-check.patch
new file mode 100644
index 0000000000..d17fdff455
--- /dev/null
+++ b/meta/recipes-rt/rt-tests/files/hackbench-fix-error-check.patch
@@ -0,0 +1,41 @@
+childinfo_t is a union that contains both signed (error) and unsigned
+(threadid) members. Thus a large threadid could appear as a negative error
+value, which will cause unexpected failures.
+
+childinfo_t should be changed to a struct, but it could potentially affect the
+performance. So we keep it as a union but only check error against -1. There is
+still a chance of false alarm but it's small.
+
+Upstream-Status: Pending
+
+Signed-off-by: Song.Li <Song.Li@windriver.com>
+Signed-off-by: Jesse Zhang <sen.zhang@windriver.com>
+---
+ src/hackbench/hackbench.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/hackbench/hackbench.c b/src/hackbench/hackbench.c
+index 8baeb23..dc0de8f 100644
+--- a/src/hackbench/hackbench.c
++++ b/src/hackbench/hackbench.c
+@@ -317,7 +317,7 @@ static unsigned int group(childinfo_t *child,
+ ctx->wakefd = wakefd;
+
+ child[tab_offset+i] = create_worker(ctx, (void *)(void *)receiver);
+- if( child[tab_offset+i].error < 0 ) {
++ if( child[tab_offset+i].error == -1 ) {
+ return (i > 0 ? i-1 : 0);
+ }
+ snd_ctx->out_fds[i] = fds[1];
+@@ -332,7 +332,7 @@ static unsigned int group(childinfo_t *child,
+ snd_ctx->num_fds = num_fds;
+
+ child[tab_offset+num_fds+i] = create_worker(snd_ctx, (void *)(void *)sender);
+- if( child[tab_offset+num_fds+i].error < 0 ) {
++ if( child[tab_offset+num_fds+i].error == -1 ) {
+ return (num_fds+i)-1;
+ }
+ }
+--
+1.7.9.5
+