diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-01-23 17:43:40 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-01-23 23:30:44 +0000 |
| commit | ad750dd1cc9d789abe723daddd098ce41d8547f5 (patch) | |
| tree | a04de472a68fb60b1a783b3065cd06f6e096a44e /meta/classes/staging.bbclass | |
| parent | da58e27a0f8fc8200f1953f05888834abd79c9f8 (diff) | |
| download | openembedded-core-ad750dd1cc9d789abe723daddd098ce41d8547f5.tar.gz | |
classes/oeqa: Replace subprocess.check_call() with check_output()
If you use subprocess.check_output() the traceback will contain the output
when the command fails which is very useful for debugging. There is no
good reason not to use this everywhere.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/staging.bbclass')
| -rw-r--r-- | meta/classes/staging.bbclass | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass index 1a4668e5d3..fc387eaf4b 100644 --- a/meta/classes/staging.bbclass +++ b/meta/classes/staging.bbclass @@ -290,7 +290,7 @@ def staging_processfixme(fixme, target, recipesysroot, recipesysrootnative, d): fixme_path = d.getVar(fixmevar) cmd += " -e 's:FIXME_%s:%s:g'" % (fixmevar, fixme_path) bb.note(cmd) - subprocess.check_call(cmd, shell=True) + subprocess.check_output(cmd, shell=True) def staging_populate_sysroot_dir(targetsysroot, nativesysroot, native, d): @@ -333,7 +333,7 @@ def staging_populate_sysroot_dir(targetsysroot, nativesysroot, native, d): staging_processfixme(fixme, targetdir, targetsysroot, nativesysroot, d) for p in postinsts: - subprocess.check_call(p, shell=True) + subprocess.check_output(p, shell=True) # # Manifests here are complicated. The main sysroot area has the unpacked sstate @@ -561,7 +561,7 @@ python extend_recipe_sysroot() { staging_processfixme(fixme[f], multilibs[f].getVar("RECIPE_SYSROOT"), recipesysroot, recipesysrootnative, d) for p in postinsts: - subprocess.check_call(p, shell=True) + subprocess.check_output(p, shell=True) for dep in configuredeps: c = setscenedeps[dep][0] |