diff options
authorChen Qi <Qi.Chen@windriver.com>2014-06-19 10:11:33 +0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2014-06-24 10:57:32 +0100
commit468d3e60ee10348578f78f846e87c02359fdb8bf (patch)
parent8277c71747758e2ba0815a6f5cd11c9e0c9c90ce (diff)
populate-extfs.sh: error out if debugfs encounters some error
Previously, even if we encounter some error when populating the ext filesystem, we don't error out and the rootfs process still succeeds. However, what's really expected is that the populate-extfs.sh script should error out if something wrong happens when using `debugfs' to generate the ext filesystem. For example, if there's not enough block in the filesystem, and allocating a block for some file fails, the failure should not be ignored. Otherwise, we will have a successful build but a corrupted filesystem. The debugfs returns 0 as long as the command is valid. That is, even if the command fails, the debugfs still returns 0. That's really a pain here. That's why this patch checks the error output to see whether there's any error logged. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
1 files changed, 6 insertions, 1 deletions
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
index da3954ea7d..23d97d39b6 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
@@ -94,4 +94,9 @@ DEBUGFS="debugfs"
echo "sif $SRC links_count $LN_CNT"
rm -fr $INODE_DIR
-} | $DEBUGFS -w -f - $DEVICE
+} | $DEBUGFS -w -f - $DEVICE 2>&1 1>/dev/null | grep '.*: .*'
+if [ $? = 0 ]; then
+ echo "Some error occured while executing [$DEBUGFS -w -f - $DEVICE]"
+ exit 1