summaryrefslogtreecommitdiffstats
path: root/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-vaapsink-downgrade-to-marginal.patch
blob: 7945a923c9c802bc20898855a76655ee40625ed0 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
From 0c28cf7bfa90f8947833722cddf23d513490c6c3 Mon Sep 17 00:00:00 2001
From: Anuj Mittal <anuj.mittal@intel.com>
Date: Wed, 28 Nov 2018 15:08:48 +0800
Subject: [PATCH] vaapsink: downgrade to marginal

Using vaapisink with default poky configuration results in an
unresponsive display as of today because DRI2 rendering is currently broken
in non composited environments [1] and libva doesn't support DRI3 [2].

Downgrade vaapisink to marginal for now so playbin (and in turn gst-play
and gtk-play examples) use xvimagesink or others out of box.

[1] https://gitlab.freedesktop.org/xorg/xserver/issues/13
[2] https://github.com/intel/libva/issues/122

Upstream-Status: Pending

Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
---
 gst/vaapi/gstvaapi.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gst/vaapi/gstvaapi.c b/gst/vaapi/gstvaapi.c
index 9a82454..4d94f2b 100644
--- a/gst/vaapi/gstvaapi.c
+++ b/gst/vaapi/gstvaapi.c
@@ -195,7 +195,6 @@ plugin_init (GstPlugin * plugin)
 {
   GstVaapiDisplay *display;
   GArray *decoders;
-  guint rank;
 
   plugin_add_dependencies (plugin);
 
@@ -220,10 +219,7 @@ plugin_init (GstPlugin * plugin)
   gst_element_register (plugin, "vaapidecodebin",
       GST_RANK_PRIMARY + 2, GST_TYPE_VAAPI_DECODE_BIN);
 
-  rank = GST_RANK_PRIMARY;
-  if (g_getenv ("WAYLAND_DISPLAY"))
-    rank = GST_RANK_MARGINAL;
-  gst_element_register (plugin, "vaapisink", rank, GST_TYPE_VAAPISINK);
+  gst_element_register (plugin, "vaapisink", GST_RANK_MARGINAL, GST_TYPE_VAAPISINK);
 
 #if USE_ENCODERS
   gst_vaapiencode_register (plugin, display);