From f335f8e744fb312b3eb599c331d08a9a6e5a8ff8 Mon Sep 17 00:00:00 2001 From: Joshua Lock Date: Thu, 28 Apr 2016 14:27:44 +0100 Subject: security_flags: turn potential string format security issues into an error Add "-Wformat -Wformat-security -Werror=format-security" to the default SECURITY_CFLAGS to catch potential security vulnerabilities due to the misuse of various string formatting functions. These flags are widely used in distributions such as Fedora and Ubuntu, however we have 15 recipes in OE-Core which fail to build with these flags included and thus the flags are removed for: - busybox - console-tools - cmake - expect - gcc - gettext - kexec-tools - leafpad - libuser - ltp - makedevs - oh-puzzles - stat - unzip - zip [YOCTO #9488] Signed-off-by: Joshua Lock Signed-off-by: Richard Purdie --- meta/conf/distro/include/security_flags.inc | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) (limited to 'meta/conf') diff --git a/meta/conf/distro/include/security_flags.inc b/meta/conf/distro/include/security_flags.inc index ff5f34e3a3..5755d28104 100644 --- a/meta/conf/distro/include/security_flags.inc +++ b/meta/conf/distro/include/security_flags.inc @@ -9,8 +9,11 @@ # -O0 which then results in a compiler warning. lcl_maybe_fortify = "${@base_conditional('DEBUG_BUILD','1','','-D_FORTIFY_SOURCE=2',d)}" -SECURITY_CFLAGS ?= "-fstack-protector-strong -pie -fpie ${lcl_maybe_fortify}" -SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-strong ${lcl_maybe_fortify}" +# Error on use of format strings that represent possible security problems +SECURITY_STRINGFORMAT ?= "-Wformat -Wformat-security -Werror=format-security" + +SECURITY_CFLAGS ?= "-fstack-protector-strong -pie -fpie ${lcl_maybe_fortify} ${SECURITY_STRINGFORMAT}" +SECURITY_NO_PIE_CFLAGS ?= "-fstack-protector-strong ${lcl_maybe_fortify} ${SECURITY_STRINGFORMAT}" SECURITY_LDFLAGS ?= "-fstack-protector-strong -Wl,-z,relro,-z,now" SECURITY_X_LDFLAGS ?= "-fstack-protector-strong -Wl,-z,relro" @@ -92,6 +95,23 @@ SECURITY_CFLAGS_pn-zlib = "${SECURITY_NO_PIE_CFLAGS}" SECURITY_CFLAGS_pn-ltp = "${SECURITY_NO_PIE_CFLAGS}" SECURITY_CFLAGS_pn-pulseaudio = "${SECURITY_NO_PIE_CFLAGS}" +# Recipes which fail to compile when elevating -Wformat-security to an error +SECURITY_STRINGFORMAT_pn-busybox = "" +SECURITY_STRINGFORMAT_pn-console-tools = "" +SECURITY_STRINGFORMAT_pn-cmake = "" +SECURITY_STRINGFORMAT_pn-expect = "" +SECURITY_STRINGFORMAT_pn-gcc = "" +SECURITY_STRINGFORMAT_pn-gettext = "" +SECURITY_STRINGFORMAT_pn-kexec-tools = "" +SECURITY_STRINGFORMAT_pn-leafpad = "" +SECURITY_STRINGFORMAT_pn-libuser = "" +SECURITY_STRINGFORMAT_pn-ltp = "" +SECURITY_STRINGFORMAT_pn-makedevs = "" +SECURITY_STRINGFORMAT_pn-oh-puzzles = "" +SECURITY_STRINGFORMAT_pn-stat = "" +SECURITY_STRINGFORMAT_pn-unzip = "" +SECURITY_STRINGFORMAT_pn-zip = "" + TARGET_CFLAGS_append_class-target = " ${SECURITY_CFLAGS}" TARGET_LDFLAGS_append_class-target = " ${SECURITY_LDFLAGS}" -- cgit 1.2.3-korg