From c101201b3aa7378e4c65a879040fe6f509e7cdcd Mon Sep 17 00:00:00 2001 From: Mariano Lopez Date: Tue, 7 Jul 2015 11:17:40 +0000 Subject: sanity.bbclass: Check if /tmp is writable Used mkstemp instead of raw open file call. Also added the exception message to the output of the sanity check. [YOCTO #7922] Signed-off-by: Mariano Lopez Signed-off-by: Ross Burton --- meta/classes/sanity.bbclass | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'meta/classes/sanity.bbclass') diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 7a580da755..125cc4c8a0 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -707,15 +707,16 @@ def check_sanity_everybuild(status, d): # Check if /tmp is writable from string import ascii_letters from random import choice - filename = "bb_writetest.%s" % os.getpid() - testfile = os.path.join("/tmp", filename) + from tempfile import mkstemp + tmpfd, tmppath = mkstemp() try: - f = open(testfile, "w") + f = os.fdopen(tmpfd, "wt") f.write("".join(choice(ascii_letters) for x in range(1024))) f.close() - os.remove(testfile) - except: - status.addresult("Failed to write into /tmp. Please verify your filesystem.") + except Exception as err: + status.addresult("Failed to write into /tmp; %s. Please verify your filesystem." % err) + finally: + os.remove(tmppath) # Check that the DISTRO is valid, if set # need to take into account DISTRO renaming DISTRO -- cgit 1.2.3-korg