From 64c8366a805e9cf0168ea2331c50c8d6a70c6dc4 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Sat, 21 Jan 2017 14:11:52 +0000 Subject: package_ipk: Improve failure debug output Currently if the dpkg-deb command fails you see an error message like this: ERROR: nss-3.27.1-r0 do_package_write_ipk: opkg-build execution failed ERROR: nss-3.27.1-r0 do_package_write_ipk: Function failed: do_package_ipk which is pretty much useless. If we use subprocess.check_output, we see a traceback and then: Exception: subprocess.CalledProcessError: Command '' returned non-zero exit status 1 Subprocess output: which is much easier to debug from. Signed-off-by: Richard Purdie --- meta/classes/package_ipk.bbclass | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'meta/classes/package_ipk.bbclass') diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass index 039b6ab69b..9fb128b82b 100644 --- a/meta/classes/package_ipk.bbclass +++ b/meta/classes/package_ipk.bbclass @@ -244,11 +244,8 @@ python do_package_ipk () { conffiles.close() os.chdir(basedir) - ret = subprocess.call("PATH=\"%s\" %s %s %s" % (localdata.getVar("PATH"), + subprocess.check_output("PATH=\"%s\" %s %s %s" % (localdata.getVar("PATH"), d.getVar("OPKGBUILDCMD"), pkg, pkgoutdir), shell=True) - if ret != 0: - bb.utils.unlockfile(lf) - bb.fatal("opkg-build execution failed") if d.getVar('IPK_SIGN_PACKAGES') == '1': ipkver = "%s-%s" % (d.getVar('PKGV'), d.getVar('PKGR')) -- cgit 1.2.3-korg