From c331f0a5cac765174a1b5de5c12aec7e965d4158 Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Thu, 9 May 2013 17:26:17 +0100 Subject: classes/insane: add check for PN in OVERRIDES If a recipe is named such that its PN value matches something already in OVERRIDES (such as when PN happens to be the same as MACHINE or DISTRO), it can have unexpected consequences. Assignments such as FILES_${PN} = "xyz" effectively turn into FILES = "xyz". Implements [YOCTO #4288]. Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie --- meta/classes/insane.bbclass | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'meta/classes/insane.bbclass') diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 4d2392e908..fb1802223a 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -907,6 +907,11 @@ python () { if d.getVar('do_stage', True) is not None: bb.fatal("Legacy staging found for %s as it has a do_stage function. This will need conversion to a do_install or often simply removal to work with OE-core" % d.getVar("FILE", True)) + overrides = d.getVar('OVERRIDES', True).split(':') + pn = d.getVar('PN', True) + if pn in overrides: + bb.warn('Recipe %s has PN of "%s" which is in OVERRIDES, this can result in unexpected behaviour.' % (d.getVar("FILE", True), pn)) + issues = [] if (d.getVar('PACKAGES', True) or "").split(): for var in 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RCONFLICTS', 'RPROVIDES', 'RREPLACES', 'FILES', 'pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm', 'ALLOW_EMPTY': -- cgit 1.2.3-korg