From b1c68e5446080f0743f7f8a530f3b00f90c8717d Mon Sep 17 00:00:00 2001 From: Tom Zanussi Date: Thu, 10 Jul 2014 13:25:14 -0500 Subject: wic: Error on parted non-zero error code The current code uses msger.debug() to note errors, effectively squelching them if --debug isn't used. Apparently this is because it can return non-zero for some loop device failures. We don't care about loop devices, and not paying attention to the error code actually results in invalid images, so error out on parted failures as we should be. Signed-off-by: Tom Zanussi Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- scripts/lib/mic/utils/partitionedfs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib/mic/utils/partitionedfs.py b/scripts/lib/mic/utils/partitionedfs.py index 6607466a83..593cf1f317 100644 --- a/scripts/lib/mic/utils/partitionedfs.py +++ b/scripts/lib/mic/utils/partitionedfs.py @@ -272,7 +272,7 @@ class PartitionedMount(Mount): # parted always fails to reload part table with loop devices. This # prevents us from distinguishing real errors based on return # code. - msger.debug("WARNING: parted returned '%s' instead of 0" % rc) + msger.error("WARNING: parted returned '%s' instead of 0 (use --debug for details)" % rc) def __create_partition(self, device, parttype, fstype, start, size): """ Create a partition on an image described by the 'device' object. """ -- cgit 1.2.3-korg