From 4fe8bb4e3f15a3f4e153605d57096c565c5fac21 Mon Sep 17 00:00:00 2001 From: Anton Eliasson Date: Fri, 8 May 2020 16:07:04 +0200 Subject: meson.bbclass: Close the log file after reading This fixes warnings like: WARNING: package-name-0.0.1-r0 do_configure: :164: ResourceWarning: unclosed file <_io.TextIOWrapper name='/source_directory/build/tmp/work/arch/package-name/0.0.1-r0/package-name-0.0.1//meson-logs/meson-log.txt' mode='r' encoding='UTF-8'> Signed-off-by: Anton Eliasson Reviewed-by: Ola x Nilsson Signed-off-by: Anton Eliasson Signed-off-by: Richard Purdie --- meta/classes/meson.bbclass | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meta/classes/meson.bbclass b/meta/classes/meson.bbclass index 06034e8b47..e9628033c6 100644 --- a/meta/classes/meson.bbclass +++ b/meta/classes/meson.bbclass @@ -164,7 +164,8 @@ meson_do_configure_prepend_class-native() { python meson_do_qa_configure() { import re warn_re = re.compile(r"^WARNING: Cross property (.+) is using default value (.+)$", re.MULTILINE) - log = open(d.expand("${B}/meson-logs/meson-log.txt")).read() + with open(d.expand("${B}/meson-logs/meson-log.txt")) as logfile: + log = logfile.read() for (prop, value) in warn_re.findall(log): bb.warn("Meson cross property %s used without explicit assignment, defaulting to %s" % (prop, value)) } -- cgit 1.2.3-korg