From 0156ef46ccf5334ee72f0202f1089249c62af37b Mon Sep 17 00:00:00 2001 From: Markus Lehtonen Date: Fri, 13 Jan 2017 15:12:38 +0200 Subject: oeqa.utils.metadata: re-organise distro information Use the same format, based on /etc/os-release, as for host distro information. [YOCTO #10590] Signed-off-by: Markus Lehtonen Signed-off-by: Ross Burton --- meta/lib/oeqa/utils/metadata.py | 17 ++++++++++------- scripts/oe-selftest | 4 ++-- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/meta/lib/oeqa/utils/metadata.py b/meta/lib/oeqa/utils/metadata.py index 2316841e0f..df6ed91052 100644 --- a/meta/lib/oeqa/utils/metadata.py +++ b/meta/lib/oeqa/utils/metadata.py @@ -10,9 +10,7 @@ from collections.abc import MutableMapping from xml.dom.minidom import parseString from xml.etree.ElementTree import Element, tostring -from oeqa.utils.commands import runCmd, get_bb_var, get_bb_vars - -metadata_vars = ['MACHINE', 'DISTRO', 'DISTRO_VERSION'] +from oeqa.utils.commands import runCmd, get_bb_vars def get_os_release(): """Get info from /etc/os-release as a dict""" @@ -35,9 +33,14 @@ def metadata_from_bb(): info_dict = OrderedDict() hostname = runCmd('hostname') info_dict['hostname'] = hostname.output - data_dict = get_bb_vars(metadata_vars) - for var in metadata_vars: - info_dict[var.lower()] = data_dict[var] + data_dict = get_bb_vars() + + info_dict['machine'] = data_dict['MACHINE'] + + # Distro information + info_dict['distro'] = {'id': data_dict['DISTRO'], + 'version_id': data_dict['DISTRO_VERSION'], + 'pretty_name': '%s %s' % (data_dict['DISTRO'], data_dict['DISTRO_VERSION'])} # Host distro information os_release = get_os_release() @@ -47,7 +50,7 @@ def metadata_from_bb(): if key in os_release: info_dict['host_distro'][key] = os_release[key] - info_dict['layers'] = get_layers(get_bb_var('BBLAYERS')) + info_dict['layers'] = get_layers(data_dict['BBLAYERS']) return info_dict def metadata_from_data_store(d): diff --git a/scripts/oe-selftest b/scripts/oe-selftest index 120a6c2de8..c3c491f20a 100755 --- a/scripts/oe-selftest +++ b/scripts/oe-selftest @@ -632,8 +632,8 @@ def main(): for layer, values in metadata['layers'].items(): layer_info = '%s%-17s = %s:%s\n' % (layer_info, layer, values['branch'], values['revision']) - msg = 'Selftest for build %s of %s %s for machine %s on %s\n\n%s' % ( - log_prefix[12:], metadata['distro'], metadata['distro_version'], + msg = 'Selftest for build %s of %s for machine %s on %s\n\n%s' % ( + log_prefix[12:], metadata['distro']['pretty_name'], metadata['machine'], metadata['hostname'], layer_info) log.debug('Commiting results to local repository') -- cgit 1.2.3-korg