aboutsummaryrefslogtreecommitdiffstats
path: root/meta/recipes-devtools/perl/perl/fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff
diff options
context:
space:
mode:
Diffstat (limited to 'meta/recipes-devtools/perl/perl/fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff')
-rw-r--r--meta/recipes-devtools/perl/perl/fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff44
1 files changed, 44 insertions, 0 deletions
diff --git a/meta/recipes-devtools/perl/perl/fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff b/meta/recipes-devtools/perl/perl/fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff
new file mode 100644
index 0000000000..011d66ae03
--- /dev/null
+++ b/meta/recipes-devtools/perl/perl/fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff
@@ -0,0 +1,44 @@
+From af80a2d91b13dff65a495663dd9bd68d7880b9fb Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
+Date: Fri, 8 Jun 2018 11:45:40 +0100
+Subject: [PATCH] Remove existing files before overwriting them
+
+Archive should extract only the latest same-named entry.
+Extracted regular file should not be writtent into existing block
+device (or any other one).
+
+Signed-off-by: Chris 'BinGOs' Williams <chris@bingosnet.co.uk>
+Bug: https://rt.cpan.org/Ticket/Display.html?id=125523
+Bug-Debian: https://bugs.debian.org/900834
+Origin: upstream, https://github.com/jib/archive-tar-new/commit/ae65651eab053fc6dc4590dbb863a268215c1fc5
+Patch-Name: fixes/CVE-2018-12015-Archive-Tar-directory-traversal.diff
+
+---
+ cpan/Archive-Tar/lib/Archive/Tar.pm | 14 ++++++++++++++
+ 1 file changed, 14 insertions(+)
+
+diff --git a/cpan/Archive-Tar/lib/Archive/Tar.pm b/cpan/Archive-Tar/lib/Archive/Tar.pm
+index d63e586..4861ea7 100644
+--- a/cpan/Archive-Tar/lib/Archive/Tar.pm
++++ b/cpan/Archive-Tar/lib/Archive/Tar.pm
+@@ -845,6 +845,20 @@ sub _extract_file {
+ return;
+ }
+
++ ### If a file system already contains a block device with the same name as
++ ### the being extracted regular file, we would write the file's content
++ ### to the block device. So remove the existing file (block device) now.
++ ### If an archive contains multiple same-named entries, the last one
++ ### should replace the previous ones. So remove the old file now.
++ ### If the old entry is a symlink to a file outside of the CWD, the new
++ ### entry would create a file there. This is CVE-2018-12015
++ ### <https://rt.cpan.org/Ticket/Display.html?id=125523>.
++ if (-l $full || -e _) {
++ if (!unlink $full) {
++ $self->_error( qq[Could not remove old file '$full': $!] );
++ return;
++ }
++ }
+ if( length $entry->type && $entry->is_file ) {
+ my $fh = IO::File->new;
+ $fh->open( '>' . $full ) or (