diff options
| author |   Mike Crowe <mac@mcrowe.com> | 2013-11-25 15:20:14 +0000 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-11-25 16:14:15 +0000 |
| commit | bc28e3f26e7f85af82f403924c0ae29e1ad34a87 (patch) | |
| tree | 631e4cb133b87cbaab291a0f82477d8663dc382d /meta/classes/sanity.bbclass | |
| parent | 11a9cf5ee0daf82097fb2f36b58016f20a5968f3 (diff) | |
| download | openembedded-core-contrib-bc28e3f26e7f85af82f403924c0ae29e1ad34a87.tar.gz | |
sanity: Use random filename for maximum path length test
check_create_long_filename used a fixed filename for its test files. This
meant that os.remove(testfile) could fail with ENOENT if two instances were
running at the same time against the same sstate directory. Using a
randomly generated filename stops this from happening.
(Although it might seem unlikely, this race did appear to occur multiple
times with Jenkins - presumably because the matrix jobs were all kicked off
at the same time.)
Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/sanity.bbclass')
| -rw-r--r-- | meta/classes/sanity.bbclass | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index b26ea6b372..8531df16b0 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -175,7 +175,8 @@ def check_conf_exists(fn, data): return False def check_create_long_filename(filepath, pathname): - testfile = os.path.join(filepath, ''.join([`num`[-1] for num in xrange(1,200)])) + import string, random + testfile = os.path.join(filepath, ''.join(random.choice(string.ascii_letters) for x in range(200))) try: if not os.path.exists(filepath): bb.utils.mkdirhier(filepath) |