diff options
| author |   Jacob Kroon <jacob.kroon@mikrodidakt.se> | 2014-01-27 22:00:21 +0100 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-01-28 11:41:02 +0000 |
| commit | a2241a92fc48e4286de17b23124a9e2f0fd8185b (patch) | |
| tree | e77bc22a0629fb27535eacd35020a2e7cce56233 /meta/classes/cml1.bbclass | |
| parent | 9d1cdb59cb9fcbc4927f04a226405766ab3c4fc8 (diff) | |
| download | openembedded-core-contrib-a2241a92fc48e4286de17b23124a9e2f0fd8185b.tar.gz | |
cml1.bbclass: Fix return code handling in do_menuconfig()
On my system, doing "bitbake -c menuconfig busybox" pops up
a gnome-terminal, I can see that the compilation starts but then the
terminal automatically exits.
It turns out I don't have ncurses development package installed on my host,
and OE's host sysroot isn't being passed to gcc, so compilation fails.
The window automatically closes before I can read the error message
since the '$' in the return code check needs to be escaped.
Make sure the user can read the error message by properly checking the
return code.
Signed-off-by: Jacob Kroon <jacob.kroon@mikrodidakt.se>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/classes/cml1.bbclass')
| -rw-r--r-- | meta/classes/cml1.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass index bb9563948c..e292ecbcf4 100644 --- a/meta/classes/cml1.bbclass +++ b/meta/classes/cml1.bbclass @@ -21,7 +21,7 @@ python do_menuconfig() { except OSError: mtime = 0 - oe_terminal("${SHELL} -c \"make menuconfig; if [ $? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d) + oe_terminal("${SHELL} -c \"make menuconfig; if [ \$? -ne 0 ]; then echo 'Command failed.'; printf 'Press any key to continue... '; read r; fi\"", '${PN} Configuration', d) # FIXME this check can be removed when the minimum bitbake version has been bumped if hasattr(bb.build, 'write_taint'): |