diff options
| author |   Ulf Magnusson <ulfalizer@gmail.com> | 2016-10-01 04:47:08 +0200 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-10-03 15:46:21 +0100 |
| commit | 8443b6f3f25181f5ac49bc25a1387cd05b814376 (patch) | |
| tree | efe9ac4503c28f2d06a5c0df5425161765e8e6ed | |
| parent | 5369bb7fa6238cc85f0b5263519974c1a2d9eea8 (diff) | |
| download | openembedded-core-contrib-8443b6f3f25181f5ac49bc25a1387cd05b814376.tar.gz | |
package.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.
Motivating quote below:
< kergoth> the *original* intent was for the function/task to error via
whatever appropriate means, bb.fatal, whatever, and
funcfailed was what you'd catch if you were calling
exec_func/exec_task. that is, it's what those functions
raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself
FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/classes/package.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index a9ca14164b..a6f0a7a63d 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1171,7 +1171,7 @@ python populate_packages () { continue ret = bb.utils.copyfile(file, fpath) if ret is False or ret == 0: - raise bb.build.FuncFailed("File population failed") + bb.fatal("File population failed") # Check if symlink paths exist for file in symlink_paths: |