summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Eggleton <paul.eggleton@linux.intel.com>2016-12-22 09:23:25 +1300
committerPaul Eggleton <paul.eggleton@linux.intel.com>2016-12-22 15:16:40 +1300
commitf146f38cc63cc6a9d8bfb642bc955797d26338eb (patch)
treeddf1a9108a96b1390b73cc10a11359febf021bbe
parentfc6a2fc60d142a7c56bde2a86b172da7ff5f40cd (diff)
downloadopenembedded-core-contrib-f146f38cc63cc6a9d8bfb642bc955797d26338eb.tar.gz
openembedded-core-contrib-f146f38cc63cc6a9d8bfb642bc955797d26338eb.tar.bz2
openembedded-core-contrib-f146f38cc63cc6a9d8bfb642bc955797d26338eb.zip
lib/oe/path: add warning comment about oe.path.remove() with wildcarded filenames
Add a warning in the doc comment for oe.path.remove() about using that function on paths that may contain wildcards in the actual file/directory names. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
-rw-r--r--meta/lib/oe/path.py9
1 files changed, 8 insertions, 1 deletions
diff --git a/meta/lib/oe/path.py b/meta/lib/oe/path.py
index 804ecd5fea..d4685403c5 100644
--- a/meta/lib/oe/path.py
+++ b/meta/lib/oe/path.py
@@ -92,7 +92,14 @@ def copyhardlinktree(src, dst):
copytree(src, dst)
def remove(path, recurse=True):
- """Equivalent to rm -f or rm -rf"""
+ """
+ Equivalent to rm -f or rm -rf
+ NOTE: be careful about passing paths that may contain filenames with
+ wildcards in them (as opposed to passing an actual wildcarded path) -
+ since we use glob.glob() to expand the path. Filenames containing
+ square brackets are particularly problematic since the they may not
+ actually expand to match the original filename.
+ """
for name in glob.glob(path):
try:
os.unlink(name)