aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRobert Yang <liezhi.yang@windriver.com>2016-01-20 23:57:30 -0800
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-02-18 22:55:11 +0000
commitf8754281451bbb64c3d26bbdbf1e596271534469 (patch)
treeda818034be5bf5df467e5149b868a906cccbbad1
parentdfb0064fb16eba1446b8f3db13e0b8b3b4764481 (diff)
downloadopenembedded-core-contrib-f8754281451bbb64c3d26bbdbf1e596271534469.tar.gz
openembedded-core-contrib-f8754281451bbb64c3d26bbdbf1e596271534469.tar.bz2
openembedded-core-contrib-f8754281451bbb64c3d26bbdbf1e596271534469.zip
insane.bbclass: print more info for build-deps and file-rdeps
This is useful for oe newbie: * build-deps: print recipe name, and suggest fixing from DEPENDS or PACKAGECONFIG, for example: WARNING: QA Issue: patch rdepends on libattr, but it isn't a build dependency, missing attr in DEPENDS or PACKAGECONFIG? [build-deps] * file-rdeps: print RDEPENDS_pkg rather than RDEPENDS, for example: WARNING: QA Issue: /sbin/osd_login contained in package nfs-utils requires /bin/bash, but no providers found in RDEPENDS_nfs-utils? [file-rdeps] Fix a bug in file-rdeps, there was "@underscore@" in file-rdeps: WARNING: QA Issue: /sbin/osd@underscore@login_nfs-utils contained in [snip] [YOCTO #8922] [YOCTO #8847] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/insane.bbclass9
1 files changed, 6 insertions, 3 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 241ad0850ba..61936e13774 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -845,7 +845,10 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
break
if rdep_data and 'PN' in rdep_data and rdep_data['PN'] in taskdeps:
continue
- error_msg = "%s rdepends on %s, but it isn't a build dependency?" % (pkg, rdepend)
+ if rdep_data and 'PN' in rdep_data:
+ error_msg = "%s rdepends on %s, but it isn't a build dependency, missing %s in DEPENDS or PACKAGECONFIG?" % (pkg, rdepend, rdep_data['PN'])
+ else:
+ error_msg = "%s rdepends on %s, but it isn't a build dependency?" % (pkg, rdepend)
package_qa_handle_error("build-deps", error_msg, d)
if "file-rdeps" not in skip:
@@ -911,8 +914,8 @@ def package_qa_check_rdepends(pkg, pkgdest, skip, taskdeps, packages, d):
break
if filerdepends:
for key in filerdepends:
- error_msg = "%s contained in package %s requires %s, but no providers found in its RDEPENDS" % \
- (filerdepends[key],pkg, key)
+ error_msg = "%s contained in package %s requires %s, but no providers found in RDEPENDS_%s?" % \
+ (filerdepends[key].replace("_%s" % pkg, "").replace("@underscore@", "_"), pkg, key, pkg)
package_qa_handle_error("file-rdeps", error_msg, d)
def package_qa_check_deps(pkg, pkgdest, skip, d):