diff options
| author |   Paul Eggleton <paul.eggleton@linux.intel.com> | 2016-12-13 20:07:14 +1300 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-12-14 09:54:48 +0000 |
| commit | 58c60a951229dcbd8253863fb24228d046c23f6e (patch) | |
| tree | 9ef51cc0ba0575db99ba7fc3e32510f6301a7f32 | |
| parent | 5a80c0e210f26526afbe8f266b7b1a9c03334967 (diff) | |
| download | openembedded-core-contrib-58c60a951229dcbd8253863fb24228d046c23f6e.tar.gz | |
server/process: don't change UI process signal handler on terminate
On terminating the connection to the server, we were disabling SIGINT -
and this is executed on the UI side. I'm not sure whether the intention
here was to undo the SIGINT disabling we did in the server, and it was
just a mistake that it disabled rather than restored and it's run on the
wrong side, or whether we wanted to stop the user from breaking out of
the shutdown code - the commit message provides no clues either way.
Regardless, we do not want to permanently disable Ctrl+C here - it's
legitimate to terminate the connection to the server and then
re-establish it within the same process; at least currently, devtool
modify by virtue of using tinfoil in two separate parts of the code does
this, and the result of this disabling is that during the second tinfoil
usage we can potentially be parsing all recipes without the ability to
easily interrupt the process.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/server/process.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py index 1654faf92b..1036366abb 100644 --- a/lib/bb/server/process.py +++ b/lib/bb/server/process.py @@ -224,7 +224,6 @@ class BitBakeProcessServerConnection(BitBakeBaseServerConnection): if isinstance(event, logging.LogRecord): logger.handle(event) - signal.signal(signal.SIGINT, signal.SIG_IGN) self.procserver.stop() while self.procserver.is_alive(): |