summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMariano Lopez <mariano.lopez@linux.intel.com>2016-08-03 13:21:30 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-09-23 15:26:17 +0100
commit8d46dc71cead3779f00537e0cace577767304f75 (patch)
tree819a21bc0a381e4b6534e21a99ec8982de2fdcf6
parent8edaf4e9592877a4cb48c2f5c896c11a129a5404 (diff)
downloadopenembedded-core-contrib-8d46dc71cead3779f00537e0cace577767304f75.tar.gz
openembedded-core-contrib-8d46dc71cead3779f00537e0cace577767304f75.tar.bz2
openembedded-core-contrib-8d46dc71cead3779f00537e0cace577767304f75.zip
python-smartpm_git.bb: Add patch for debugging random errors
This will add a patch to debug random errors seen in the autobuilders, it won't solve the errors, but will give us a better idea of what is happening. [YOCTO #8383] (From OE-Core rev: c52a7e910a3a52a7455a2409d9ade449bbbd66d4) Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
-rw-r--r--meta/recipes-devtools/python/python-smartpm/smart-add-deugging-when-targetpath-is-empty.patch47
-rw-r--r--meta/recipes-devtools/python/python-smartpm_git.bb1
2 files changed, 48 insertions, 0 deletions
diff --git a/meta/recipes-devtools/python/python-smartpm/smart-add-deugging-when-targetpath-is-empty.patch b/meta/recipes-devtools/python/python-smartpm/smart-add-deugging-when-targetpath-is-empty.patch
new file mode 100644
index 0000000000..5e80804bf4
--- /dev/null
+++ b/meta/recipes-devtools/python/python-smartpm/smart-add-deugging-when-targetpath-is-empty.patch
@@ -0,0 +1,47 @@
+From 01e51afd03131947f8d74b9a23fdbc0078249499 Mon Sep 17 00:00:00 2001
+From: Mariano Lopez <mariano.lopez@linux.intel.com>
+Date: Wed, 3 Aug 2016 07:47:09 +0000
+Subject: [PATCH] fetcher.py: Add debugging when targetpath is empty
+
+There are several errors when openining files or manipulating
+path strings, those errors point targetpath passed to
+setSucceeded() is empty. This patch won't solve the problems,
+but will add debugging to give an idea why is failing.
+
+Upstream-Status: Inappropriate [debugging]
+
+Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
+---
+ smart/fetcher.py | 16 ++++++++++++++++
+ 1 file changed, 16 insertions(+)
+
+diff --git a/smart/fetcher.py b/smart/fetcher.py
+index dd3ff6b..64aa979 100644
+--- a/smart/fetcher.py
++++ b/smart/fetcher.py
+@@ -594,6 +594,22 @@ class FetchItem(object):
+ self._eta = None
+
+ def setSucceeded(self, targetpath, fetchedsize=0):
++ # It seems the in some odd cases targetpath here
++ # is empty, this will lead to bugs in several places
++ if not targetpath:
++ import traceback
++ tb_str = ""
++ for threadId, stack in sys._current_frames().items():
++ tb_str += '\nThreadID: %s' % threadId
++ for filename, lineno, name, line in traceback.extract_stack(stack):
++ tb_str += '\nFile: "%s", line %d, in %s' % (filename, lineno, name)
++ if line:
++ tb_str += "\n %s" % line.strip()
++ error_string = ["No file path specified",
++ "URL: %s" % self._url,
++ "Status: %s" % self._status,
++ "Traceback: %s" % tb_str]
++ raise Error, _("\n".join(error_string))
+ if self._status is not FAILED:
+ self._status = SUCCEEDED
+ self._targetpath = targetpath
+--
+2.6.6
+
diff --git a/meta/recipes-devtools/python/python-smartpm_git.bb b/meta/recipes-devtools/python/python-smartpm_git.bb
index 53e651a824..e6dd02ed5e 100644
--- a/meta/recipes-devtools/python/python-smartpm_git.bb
+++ b/meta/recipes-devtools/python/python-smartpm_git.bb
@@ -25,6 +25,7 @@ SRC_URI = "\
file://smart-channel-remove-all.patch \
file://smart-locale.patch \
file://smartpm-rpm5-support-check-signatures.patch \
+ file://smart-add-deugging-when-targetpath-is-empty.patch \
"
SRCREV = "407a7eca766431257dcd1da15175cc36a1bb22d0"