aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoss Burton <ross.burton@arm.com>2020-06-15 14:44:12 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2020-06-16 15:20:01 +0100
commitb00e28735b64a781707441ec6187dd7f9240d97a (patch)
tree90212c94c13acaec6a5de03e5ca489ce28681e9c
parentf9c5df6dc1c13e9b05ff1b47ad84ad339f6779a4 (diff)
downloadopenembedded-core-contrib-b00e28735b64a781707441ec6187dd7f9240d97a.tar.gz
openembedded-core-contrib-b00e28735b64a781707441ec6187dd7f9240d97a.tar.bz2
openembedded-core-contrib-b00e28735b64a781707441ec6187dd7f9240d97a.zip
install-buildtools: fail if an error occurs
Several failure paths were displaying an error message but not returning, so the install process continued and failed further. Signed-off-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rwxr-xr-xscripts/install-buildtools2
1 files changed, 2 insertions, 0 deletions
diff --git a/scripts/install-buildtools b/scripts/install-buildtools
index c6b3a1eed72..d722519f0f8 100755
--- a/scripts/install-buildtools
+++ b/scripts/install-buildtools
@@ -258,6 +258,7 @@ def main():
else:
logger.error("Checksum %s expected. Actual checksum is %s." %
(checksum, checksum_value))
+ return 1
# Make installer executable
logger.info("Making installer executable")
@@ -273,6 +274,7 @@ def main():
ret = subprocess.call("%s -y" % tmpbuildtools, shell=True)
if ret != 0:
logger.error("Could not run buildtools installer")
+ return ret
# Setup the environment
logger.info("Setting up the environment")