From 14c17480827ced2e03c1b62dc839696421fc4de8 Mon Sep 17 00:00:00 2001 From: "Mardegan, Alberto" Date: Thu, 21 Sep 2017 14:33:52 +0000 Subject: bitbake: lib/bb/utils: fix movefile() copy to dir fallback When the destination is a directory, building the the destination file path is always needed. That's because even if the copy fallback is taken, it's always followed by a rename. Signed-off-by: Alberto Mardegan Signed-off-by: Richard Purdie --- lib/bb/utils.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'lib') diff --git a/lib/bb/utils.py b/lib/bb/utils.py index 8550af34a..c540b49cf 100644 --- a/lib/bb/utils.py +++ b/lib/bb/utils.py @@ -771,13 +771,14 @@ def movefile(src, dest, newmtime = None, sstat = None): return None renamefailed = 1 + # os.rename needs to know the dest path ending with file name + # so append the file name to a path only if it's a dir specified + srcfname = os.path.basename(src) + destpath = os.path.join(dest, srcfname) if os.path.isdir(dest) \ + else dest + if sstat[stat.ST_DEV] == dstat[stat.ST_DEV]: try: - # os.rename needs to know the dest path ending with file name - # so append the file name to a path only if it's a dir specified - srcfname = os.path.basename(src) - destpath = os.path.join(dest, srcfname) if os.path.isdir(dest) \ - else dest os.rename(src, destpath) renamefailed = 0 except Exception as e: @@ -791,8 +792,8 @@ def movefile(src, dest, newmtime = None, sstat = None): didcopy = 0 if stat.S_ISREG(sstat[stat.ST_MODE]): try: # For safety copy then move it over. - shutil.copyfile(src, dest + "#new") - os.rename(dest + "#new", dest) + shutil.copyfile(src, destpath + "#new") + os.rename(destpath + "#new", destpath) didcopy = 1 except Exception as e: print('movefile: copy', src, '->', dest, 'failed.', e) @@ -813,9 +814,9 @@ def movefile(src, dest, newmtime = None, sstat = None): return None if newmtime: - os.utime(dest, (newmtime, newmtime)) + os.utime(destpath, (newmtime, newmtime)) else: - os.utime(dest, (sstat[stat.ST_ATIME], sstat[stat.ST_MTIME])) + os.utime(destpath, (sstat[stat.ST_ATIME], sstat[stat.ST_MTIME])) newmtime = sstat[stat.ST_MTIME] return newmtime -- cgit 1.2.3-korg