summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2013-05-07prserv/cooker: Handle PRService errors cleanly1.16Richard Purdie
Current if the PR Service fails to start, bitbake carries on regardless or hangs with no error message. This adds an exception and then handles it correctly so the UIs correctly handle the error and exit cleanly. [YOCTO #4010] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-04-12codeparser: Track bb.utils.contains usageRichard Purdie
The bb.utils.contains function usage is getting increasingly used in the metadata but isn't handled automatically by the python dependency tracking code. This patch changes that and also adds the "OE" names for the functions. Whilst there are reasons this is a bad idea, its likely outweighed by the shear number of these references and the current holes in dependency information which we're now relying heavily upon. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-04-12codeparser: Track appendVar and prependVar calls as we do for getVarRichard Purdie
We need to track appendVar and prependVar calls just as we do for getVar in order to ensure we're not missing variable dependencies. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-03-04knotty.py: fix unknown event bb.event.DiskFullRobert Yang
There is an error: ERROR: No new tasks can be excuted since the disk space monitor action is "STOPTASKS"! ERROR: Unknown event: <bb.event.DiskFull object at 0x2ab6310> This is because we don't handle the event bb.event.DiskFull in knotty.py, we don't want the knotty to do anything here since we have done everything in monitordisk.py, so just ignore this event would fix the problem. [YOCTO #3523] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-03-03ssh.py: add example SRC_URIMartin Jansa
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-03-03ssh.py: throw ParameterError when someone tries ssh://foo; protocol=gitMartin Jansa
* taken from SFTP fetcher: http://patchwork.openembedded.org/patch/43027/ Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-03-03ssh: fix fetcherMartin Jansa
* set localpath in urldata_init otherwise localpath and basename were None, when fetcher was trying to define .lock and .done paths basepath = d.expand("${DL_DIR}/%s" % os.path.basename(self.localpath or self.basename)) * remove "host" from localpath .done and .lock files are always using just basename, so if someone has 2 recipes with: SRC_URI = "ssh://foo/file.txt" SRC_URI = "ssh://bar/file.txt" then there will be only one file.txt.done in downloads anyway (and only first file.txt from first server will be returned on do_fetch Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-02-26build.py: avoid deleting taint files when writing stampsPaul Eggleton
The stamp cleaning process that occurs before writing out new stamps for a task was deleting taint files as well. This resulted in tasks that were forcibly re-executed using the -f or -C command line options to have their previous output restored from shared state when called upon a second time, because the taint value was no longer incorporated into the task signature and thus it was reverting to its previous value. This also affected the kernel menuconfig command in OE-Core. Note that the taint file *is* still deleted when doing -c clean, which is the desired behaviour. Fixes [YOCTO #3919]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2013-02-22monitordisk.py: disable the inode checking for some fsRobert Yang
There is an error when use disk monitor on btrfs: WARNING: The free inode of rootfs is running low (0.000K left) ERROR: Immediately abort since the disk space monitor action is "ABORT"! This is beucase some fs formats' statvfs.f_files (inodes) is zero, thus the statvfs.f_favail (free inodes) is zero, too, this a feature of the fs, we disable the inode checking for such a fs. [YOCTO #3609] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-07Revert "BBHandler: Ensure parser state engine is correctly reset for new ↵Richard Purdie
parsing" This reverts commit 1a4ea02932d07c437187f67ac5b6e25ad76ee84a.
2012-12-07BBHandler: Ensure parser state engine is correctly reset for new parsingRichard Purdie
The classes variable in particular could be in an odd state if parsing of a previous recipe had abruptly ended. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-07build.py: Preserve sigdata files in the stamps directoryRichard Purdie
Leaving the sigdata files around can aid debugging and doesn't harm anything. This is the easiest way to allow this to happen. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-06data_smart: Improve get_hash to account for overrides and key expansionRichard Purdie
An issue was uncovered where changing: IMAGE_INSTALL_append = "X" to IMAGE_INSTALL_append = "X Y" in local.conf would not get noticed by bitbake. The issue is that the configuration hash doesn't account for overrides or key expansion. This patch improves get_hash to account for these. This means the hash does account for changes like the above. [YOCTO #3503] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-03build/siggen.py: Avoid removing too many stamps when cleaningRichard Purdie
The "*" part of the mask is to ensure we clean both any stamp, and any setscene varient. It turns out we would also trample other tasks, e.g. do_package_write could trample do_package_write_rpm. do_package also tramples do_package_write_* but this is less of an issue since the other tasks depend on it. Rather than use the wildcard, we can just use a list instead. [YOCTO #3484] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-03fetch2/wget: Fix for mixed-up wget commandsCristian Iorga
wget commands for check and resume were mixed-up, leading to the following issues: 1. long running "NOTE: Preparing runqueue" reason: objects were downloaded, not spidered on the mirror 2. Failing network test in Build Appliance, because wget 1.14 (in use in BA) will fail if a file already exists. During the network connectivity test, index.php file was actually downloaded, not spidered (checked for existence on yoctoproject.org website), leading to wget failure. Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-03hob: hob was freezing because it doesn't receives well the log fileCristiana Voicu
-after pressing "build image" button, hob was freezing because it didn't receive well the log file [YOCTO #3398] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-12-03command: add error to return of runCommandChristopher Larson
Currently, command.py can return an error message from runCommand, due to being unable to run the command, yet few of our UIs (just hob) can handle it today. This can result in seeing a TypeError with traceback in certain rare circumstances. To resolve this, we need a clean way to get errors back from runCommand, without having to isinstance() the return value. This implements such a thing by making runCommand also return an error (or None if no error occurred). As runCommand now has a method of returning errors, we can also alter the getCmdLineAction bits such that the returned value is just the action, not an additional message. If a sync command wants to return an error, it raises CommandError(message), and the message will be passed to the caller appropriately. Example Usage: result, error = server.runCommand(...) if error: log.error('Unable to run command: %s' % error) return 1 Signed-off-by: Christopher Larson <chris_larson@mentor.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-09hob-toolchain: task-core-standalone-sdk-target renamed to ↵Andrei Dinu
packagegroup-core-standalone-sdk-target This change also applies to task-core-standalone-sdk-target-dbg and resolves build failures caused by the missing packages. Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-08hob/imageconfigurationpage: a 'hob-image' appears listed in the base image ↵Cristiana Voicu
combo box -remove this image from image combo box [YOCTO #3230] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-08hob/hobeventhandler: Describe the runCommand failure exceptionConstantin Musca
[YOCTO #1245] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-04hob/hobeventhandler: Throw an exception if runCommand failsConstantin Musca
- throw a Hob exception if runCommand returns 'Busy' or 'No such command' [YOCTO #1245] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-03hob/imagedetailspage: disable the deploy tool for qemu machinesConstantin Musca
- qemu images cannot be deployed to hardware, even if live images (hddimg and iso) files are created [YOCTO #3196] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-03hob/settings: alignment and spacing fixes on "Shared state" tabCristiana Voicu
-alignment and separation on vertical and horizontal axis -change controls width [YOCTO #3188] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-03hob/image_details/run_image: Kernel must be setIoana Grigoropol
- when displaying image details, even if the kernel information is not shown, the kernel value must be set (if dealing with qemu) otherwise running the image will throw an error Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-03fetch2: raise an exception if user specifies protocol=git with http://Paul Eggleton
It is a common mistake to use http:// and protocol=git when attempting to fetch from a git repository using the http protocol; if this is detected then throw an error explaining that you need to use git:// with protocol=http instead. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-03providers.py: Fix PREFERRED_VERSION containing epochsRichard Purdie
For some reason the code calls int() on the epoch component of any PREFERRED_VERSION. Since this is compared against strings, the comparison would always fail. This removes the stray cast and allows epochs in preferred_version to work correctly. [YOCTO #3187] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02hob/hobpages: Generate the title label every timeConstantin Musca
- the title label is destroyed at page switching (that's why we need to generate it every time) [YOCTO #3195] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02hob: Improved behavior for error reporting windowCristian Iorga
Scrollbars have now an automatic behavior, depending on the error's text size and error window size. Fixes [YOCTO #2983] Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02Update version to 1.16.01.16.0Richard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02hob: Further improvements to hob dialogsBogdan Marinescu
1. Replace some labels in the "Build environment" tab 2. 'defaultsetup' changed to 'Default' in the "Image types" tab 3. Fixed the moving icon in the "Output" tab For more details: https://bugzilla.yoctoproject.org/show_bug.cgi?id=2162 [Yocto #2162] Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02hob: Fix 'User selected' tag functionalityConstantin Musca
- the 'User selected' tag is only used when the user selects a package - fix hob to remember which packages are 'User selected' - if the package is already brought in by some other package, it should not appear as 'User selected' [YOCTO #3108] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02hob/settings: Change the 'Delete' button behaviour in the shared state ↵Cristiana Voicu
settings tab -the tab shows an empty mirror row when no mirror is configured -able to delete the mirror row even if it's not empty(if it's not the first mirror) [YOCTO #3189] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02hob/image_details: Remove kernel info from detailsIoana Grigoropol
- removed kernel information from image details [Yocto #3002] Signed-off-by: Ioana Grigoropol <ioanax.grigoropol@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02tests/utils: Add test for explode_dep_versions2Richard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02utils: Add explode_dep_versions2 to replace explode_dep_versionsRichard Purdie
The API for explode_dep_versions is flawed since there can only be one version constraint against any given dependency. This adds a new function with an API without this limitation. explode_dep_versions() is maintained with a warning printed when its used in a situation where information is lost. This should allow a simple transition to the new API to fix the lost dependency information. join_deps() is updated to deal with data in either format. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02utils.py: Allow explode_dep_versions comparisons to have arbitrary whitespaceMark Hatle
Refactor the explode_dep_versions to be more lenient on whitespace values. The required format is: foo (= 1.10) foo (=1.10) foo ( = 1.10) foo ( =1.10) foo ( = 1.10 ) foo ( =1.10 ) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-10-02utils.py: Check for duplicate dependency entriesMark Hatle
explode_dep_versions is not able to have duplicate entries. Previously duplicate entries ended up with the last item being the one returned to the caller. We now detect a collision. We do allow an empty item to have a comparison added to it, or a duplicate with the same comparison without error. When a collision is detected a ValueError exception is thrown. Allowed: foo foo (= 1.12) foo Invalid: foo (= 1.12) foo (= 1.13) Signed-off-by: Mark Hatle <mark.hatle@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28Fix bad merge of #2162Bogdan Marinescu
This patch fixes the bad merge of #2162 fixes on master. Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28hob: Error reports are done in a clearer wayCristian Iorga
For long errors (bigger than 200 letters), the text box is scrollable and resizable and text is selectable. Additionaly, all message dialogs are modal. Otherwise, a user could still interact with hob even in an error case, leading to potential problems. See design details in related bugs. Fixes [YOCTO #2960], [YOCTO #2983] Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28hob/builddetailspage: fix failure_primary_action_button_clicked_cbConstantin Musca
[YOCTO #3194] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28hob/builddetailspage: remove "back" buttonCristiana Voicu
When a build fails, there should not be a back button on the screen. All available actions are provided within the failure notification, so no back button is needed. [YOCTO #3104] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28knotty: Allow displaying of status when no tasks are activeRichard Purdie
The console can appear to hang when no tasks are executing even if bitbake is iterating through a large number of tasks behind the scenes. This patch tweaks the footer code to display a status even when no tasks are active to give the user better feedback about what is happening. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28parse/ConfHandler: Add negative lookahead to spot some quoting problemsRichard Purdie
Syntax like: FOO = "bar" # eek" would result in FOO taking the value 'bar" #eek' which is clearly not the intention. Whilst our metadata is riddled with mixtures of even quotes like: FOO = "d.getVar("X")" odd numbers of quotes seem rare. This patch adds detection of one odd quote which we don't have any of in OE-Core so it seems a valid sanity improvement. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28hob: set modal flag on progress dialogRoss Burton
The entire interface isn't usable whilst the progress dialog is up so we might as well set the modal flag so that some WMs (such as GNOME 3) can do nice things with the dialog (such as pin it to the titlebar). Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28hob/settings: implement a new tab in settings dialog to show SSTATE_MIRRORSCristiana Voicu
Add a new tab to show correctly SSTATE_MIRRORS variable. Now you can add new mirrors or delete mirror. "info" image was also changed( it is smaller, so it can be next to labels). >From "Build environment" tab, SSTATE_DIR and SSTATE_MIRRORS vars were removed. [YOCTO #2893] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-28Add missing file from previous commitRichard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-27hob/builder: When you stop a build, Hob should tell you stopping is happeningConstantin Musca
- use the progress bar text to indicate the stopping status - the text should say: 'Stopping the build...' [YOCTO #3152] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-27lib/bb/data.py: improve output for expansion errorsPaul Eggleton
Instead of logging the function/variable separately as a NOTE when failing to expand, re-raise ExpansionError with more contextual information. This means that the full details are reported in Hob as well as actually reporting the original error message in any UI where we previously did not. For example, we used to get this with tab/space indentation issues in a python function: NOTE: Error expanding variable populate_packages ERROR: Unable to parse /path/to/recipename.bb Now, we will get this: ERROR: ExpansionError during parsing /path/to/recipename.bb: Failure expanding variable populate_packages: IndentationError: unindent does not match any outer indentation level (<string>, line 4) Fixes [YOCTO #3162]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-27cooker: adjust layer dependency error messagesPaul Eggleton
Make these a little easier to understand. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2012-09-27hob/recipeselectionpage: recipes should not be shown brought in by themselvesCristiana Voicu
[YOCTO #3107] Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>