diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-01-08 10:35:16 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-02-11 17:34:05 +0000 |
| commit | 879fe20f47ba75f4afb3484d4398d5fd60431e12 (patch) | |
| tree | 4b6dfca5e1c3e6180b83cdac321b39d1f59a4380 | |
| parent | d571149cd82028c5e05cca33a3007ce1b779a654 (diff) | |
| download | bitbake-879fe20f47ba75f4afb3484d4398d5fd60431e12.tar.gz | |
ast: Add error when trying to use dash in sh function names
A dash character is illegal in function names in sh (but not bash). Since
our shell tasks run under sh and the shell parser is sh based, EXPORT_FUNCTIONS
won't work with class names containing a dash.
We can't change sh, we can ensure the user is warned about the problem
straight away though.
[YOCTO #7006]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/parse/ast.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/bb/parse/ast.py b/lib/bb/parse/ast.py index 4e5a06e76..4b10ee701 100644 --- a/lib/bb/parse/ast.py +++ b/lib/bb/parse/ast.py @@ -226,6 +226,8 @@ class ExportFuncsNode(AstNode): if data.getVarFlag(calledfunc, "python"): data.setVar(func, " bb.build.exec_func('" + calledfunc + "', d)\n") else: + if "-" in self.classname: + bb.fatal("The classname %s contains a dash character and is calling an sh function %s using EXPORT_FUNCTIONS. Since a dash is illegal in sh function names, this cannot work, please rename the class or don't use EXPORT_FUNCTIONS." % (self.classname, calledfunc)) data.setVar(func, " " + calledfunc + "\n") data.setVarFlag(func, 'export_func', '1') |