From c0c50d43266150a80be31ae2c6fcaf37f5ba231d Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Tue, 7 Feb 2017 09:08:50 +1300 Subject: fetch2/npm: handle items only in optionalDependencies An npm package.json file has two dependency fields: dependencies and optionalDependencies. An item in optionalDependencies *may* also be listed in dependencies, but this is not required (and not necessary since if it's in optionalDependencies it will be optional, adding it to dependencies won't do anything). The code here was assuming that an optional dependency would always be in both, that's probably because that was true of the examples I was looking at at the time. To fix it, just add the optional ones to the list we're iterating over. Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie --- lib/bb/fetch2/npm.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/bb/fetch2/npm.py b/lib/bb/fetch2/npm.py index 3e352922e..8c32f81c7 100644 --- a/lib/bb/fetch2/npm.py +++ b/lib/bb/fetch2/npm.py @@ -195,6 +195,7 @@ class Npm(FetchMethod): dependencies = pdata.get('dependencies', {}) optionalDependencies = pdata.get('optionalDependencies', {}) + dependencies.update(optionalDependencies) depsfound = {} optdepsfound = {} data[pkg]['deps'] = {} -- cgit 1.2.3-korg