From 9123c287db12b826cea69f8270f3635efd205a0c Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Thu, 14 Sep 2017 15:42:44 +1200 Subject: cooker: ensure monkey-patching in collect_bbfiles() gets undone on error In collect_bbfiles() we're monkey-patching os.listdir in order to find which directories to watch, and then undoing that when we're finished - however if an exception occurred for any reason there was nothing to ensure the latter occurred. This may not have caused any issues, but as this kind of thing really ought to be secured using try...finally just in case, so do that. Signed-off-by: Paul Eggleton --- lib/bb/cooker.py | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index 6de04fcba..73a2fef28 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -1695,25 +1695,25 @@ class CookerCollectFiles(object): return origlistdir(d) os.listdir = ourlistdir - - # Can't use set here as order is important - newfiles = [] - for f in files: - if os.path.isdir(f): - dirfiles = self.find_bbfiles(f) - for g in dirfiles: - if g not in newfiles: - newfiles.append(g) - else: - globbed = glob.glob(f) - if not globbed and os.path.exists(f): - globbed = [f] - # glob gives files in order on disk. Sort to be deterministic. - for g in sorted(globbed): - if g not in newfiles: - newfiles.append(g) - - os.listdir = origlistdir + try: + # Can't use set here as order is important + newfiles = [] + for f in files: + if os.path.isdir(f): + dirfiles = self.find_bbfiles(f) + for g in dirfiles: + if g not in newfiles: + newfiles.append(g) + else: + globbed = glob.glob(f) + if not globbed and os.path.exists(f): + globbed = [f] + # glob gives files in order on disk. Sort to be deterministic. + for g in sorted(globbed): + if g not in newfiles: + newfiles.append(g) + finally: + os.listdir = origlistdir bbmask = config.getVar('BBMASK') -- cgit 1.2.3-korg