aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2023-02-17 12:34:39 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2023-02-17 15:10:03 +0000
commit13279044f16f2cf2502ebf39d277415f99bb6c18 (patch)
treefdc62e07295a853c3f2864720e830ef17f131987
parent2365d891847f8e73d1c4661ddfdab8818ff619dc (diff)
downloadbitbake-contrib-13279044f16f2cf2502ebf39d277415f99bb6c18.tar.gz
cookerdata: Drop dubious exception handling code
This code appears to be dangerous, it swallows exceptions, turning them into "handled" versions which then show no errors to the user. This is a pretty poor user experience and I can't see why this code should be swallowing such things. Drop the worst bits of code. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/bb/cookerdata.py5
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py
index 38d0b4666..adde0e744 100644
--- a/lib/bb/cookerdata.py
+++ b/lib/bb/cookerdata.py
@@ -294,14 +294,9 @@ class CookerDataBuilder(object):
bb.event.fire(bb.event.MultiConfigParsed(mcdata), self.data)
self.data_hash = data_hash.hexdigest()
- except (SyntaxError, bb.BBHandledException):
- raise bb.BBHandledException()
except bb.data_smart.ExpansionError as e:
logger.error(str(e))
raise bb.BBHandledException()
- except Exception:
- logger.exception("Error parsing configuration files")
- raise bb.BBHandledException()
bb.codeparser.update_module_dependencies(self.data)